Database migration for HMAC Key Records #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchenani
reviewed
Dec 4, 2024
|
|
||
| impl DbConnection { | ||
| /// Returns all hmac_key_records for the given group_id | ||
| pub fn get_hmac_key_records( |
There was a problem hiding this comment.
sugesstion: does impl_fetch_list_with_key! the same job?
mchenani
reviewed
Dec 4, 2024
| } | ||
|
|
||
| /// Insert hmac_key_records without replacing existing ones | ||
| pub fn insert_hmac_key_records( |
There was a problem hiding this comment.
suggestion: can we use impl_fetch_list_with_key!
|
Sorry, mistakenly updated the PR! |
nplasterer
commented
Dec 4, 2024
| @@ -0,0 +1,11 @@ | |||
| CREATE TABLE "hmac_key_records"( | |||
| -- Group ID that the Hmac keys are associated with | |||
| "group_id" BLOB NOT NULL, | |||
There was a problem hiding this comment.
I did this based off of the hmac keys work in V2 but @codabrink mentioned we might be doing this based on inboxId now. So maybe this is irrelevant in V3?
|
Some high-level thoughts, based on our previous discussion about deriving the hmac key from a user secret rather than a group secret in v3. It might be worth looping @codabrink into this PR too:
|
|
Closing out for now infavor of a more general database long term for these kinds of preferences similar to our consent records DB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #422
Adds the database table for hmac key records
Matches the structure currently used for hmac keys in V2 https://github.com/xmtp/proto/blob/main/proto/keystore_api/v1/keystore.proto#L306-L317