Native Logging with tracing for Android and iOS #1372
Merged
+225
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
force-pushed
the
insipx/ffi-tracing
branch
from
f398487 to
bdfb40e
Compare
insipx
changed the title
nplasterer
reviewed
Dec 4, 2024
| @@ -142,7 +140,6 @@ pub async fn create_client( | |||
| #[allow(unused)] | |||
| #[uniffi::export(async_runtime = "tokio")] | |||
| pub async fn get_inbox_id_for_address( | |||
| logger: Box<dyn FfiLogger>, | |||
There was a problem hiding this comment.
How will this work now for surfacing libxmtp errors in native? https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/org/xmtp/android/library/libxmtp/XMTPLogger.kt
There was a problem hiding this comment.
Ahh sorry just read you description so it should just work now with out this! Nice
There was a problem hiding this comment.
Yup just tested with android, we actually get way more info now I think:
nplasterer
approved these changes
Dec 4, 2024
insipx
force-pushed
the
insipx/ffi-tracing
branch
from
bdfb40e to
8531d74
Compare
insipx
force-pushed
the
insipx/ffi-tracing
branch
from
8531d74 to
f6b821a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
FfiLoggerwith native bindings to Android and iOS/MacLogutilities. This removes the need to pass a logger intoxmtpv3bindings, since it interacts directly with the android/ios libraries.This also makes it possible to create benchmarks in
bindings_ffi, and generate flamegraphs profiling the performance (the main reason behind opening this PR now is to profilecreate_client).Future work maybe interested in adding a non-blocking appender layer to write logs to a file and send them somewhere once a fork is detected.