Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for SQLcipher and add logs for salt/db #1348

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Check for SQLcipher and add logs for salt/db #1348

merged 1 commit into from
Nov 27, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Nov 27, 2024

  • fix the MessageStore to give actual SQLCipher extension not loaded error when extension not present
  • Add more logging around salt and db path to help partners debug their SDKS

@insipx insipx requested a review from a team as a code owner November 27, 2024 16:23
@insipx insipx requested a review from nplasterer November 27, 2024 16:23
@insipx insipx force-pushed the sqlcipher-observability branch from 91c6b23 to d9a27aa Compare November 27, 2024 16:28
@insipx insipx force-pushed the sqlcipher-observability branch from d9a27aa to a7d56af Compare November 27, 2024 16:30
@insipx insipx enabled auto-merge (squash) November 27, 2024 16:35
@insipx insipx merged commit 6ff8ae4 into main Nov 27, 2024
10 checks passed
@insipx insipx deleted the sqlcipher-observability branch November 27, 2024 16:35
@nplasterer nplasterer restored the sqlcipher-observability branch December 3, 2024 23:22
@nplasterer nplasterer deleted the sqlcipher-observability branch December 3, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @nplasterer