Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Consent Sync #1234

Merged
merged 50 commits into from
Nov 18, 2024
Merged

Live Consent Sync #1234

merged 50 commits into from
Nov 18, 2024

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Nov 7, 2024 •
edited
Loading

Add consent streaming to update consent records to other devices in real-time when a history_sync_url is provided.

xmtp/proto#227

codabrink and others added 30 commits November 7, 2024 15:19
@codabrink
update proto
5711e5c
@codabrink
process streamed updates
0740a60
@codabrink
first stream update location
cd256bf
@codabrink
use local events to dispatch update
5aa4eb4
@codabrink
optional buffer on the local events
4f5f030
@codabrink
cleanup
7462e5e
@codabrink
rename
33c6cca
@codabrink
cleanup
5bf9d7f
@codabrink
add warn
448b7b7
@codabrink
Merge branch 'main' into coda/consent-streaming
0580930
@codabrink
lint
fb5f7c0
@codabrink
Merge branch 'coda/consent-streaming' of github.com:xmtp/libxmtp into…
2a322b3 
… coda/consent-streaming
@codabrink
logs
5472c9a
@codabrink
Merge branch 'main' of github.com:xmtp/libxmtp
8339858
@codabrink
wip
4f82cfc
@codabrink
cleanup
05f3642
@codabrink
Merge branch 'main' into coda/sync-cleanup
95f2609
@codabrink
remove comment
5e5834e
@codabrink
Merge branch 'coda/sync-cleanup' of github.com:xmtp/libxmtp into coda…
0215384 
…/sync-cleanup
@codabrink
syncable groups fix
b1faa6b
@codabrink
revert this file
4441039
@codabrink
invert the approach
2b18f0e
@codabrink
add down
da7b64a
@codabrink
wip
fec69f5
@codabrink
Merge remote-tracking branch 'origin/coda/sync-cleanup' into coda/con…
5f334c9 
…sent-streaming
@codabrink
Merge remote-tracking branch 'origin/main' into coda/consent-streaming
43f2469
@codabrink
wip tests
d69ddd2
@codabrink
Merge remote-tracking branch 'origin/main' into coda/consent-streaming
80bdc9d
@codabrink
ignore non sync msgs
51ff591
@codabrink
cleanup, test fix
0ca52c3
@codabrink codabrink marked this pull request as ready for review November 18, 2024 19:09
@codabrink codabrink requested a review from a team as a code owner November 18, 2024 19:09
@codabrink codabrink changed the title Coda/consent streaming Consent streaming Nov 18, 2024
@codabrink codabrink changed the title Consent streaming Live Consent Sync Nov 18, 2024
@cameronvoell cameronvoell self-requested a review November 18, 2024 21:44
cameronvoell
cameronvoell approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@codabrink codabrink merged commit 0b0bcde into main Nov 18, 2024
10 checks passed
@codabrink codabrink deleted the coda/consent-streaming branch November 18, 2024 21:44
nplasterer added a commit that referenced this pull request Nov 19, 2024
@nplasterer
Revert "Live Consent Sync (#1234)"
cb669ad 
This reverts commit 0b0bcde.
nplasterer added a commit that referenced this pull request Nov 19, 2024
@nplasterer
Revert "Live Consent Sync (#1234)" (#1288)
46e3bc7 
* Revert "Live Consent Sync (#1234)"

This reverts commit 0b0bcde.

* fix bad merge
@codabrink codabrink restored the coda/consent-streaming branch November 19, 2024 14:08
nplasterer added a commit that referenced this pull request Nov 26, 2024
@nplasterer
Sync all conversations syncs all (#1340)
14df3bc 
* Revert "Live Consent Sync (#1234)"

This reverts commit 0b0bcde.

* make sync all sync all

* do the web side

* clean up the logic

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codabrink @cameronvoell @nplasterer