Skip to content

Commit

Permalink
Refactor of stream_all_messages, fix flaky stream tests (#835)
Browse files Browse the repository at this point in the history
* quick pass at stream_all_msg refactor

* tests pass

* try replacing StreamCloser with JoinHandle

* use Notify

* lose all messages test is definitely still flaky
  • Loading branch information
insipx authored Jul 16, 2024
1 parent d65eb42 commit 79b6c7b
Show file tree
Hide file tree
Showing 14 changed files with 664 additions and 440 deletions.
99 changes: 98 additions & 1 deletion bindings_ffi/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions bindings_ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ xmtp_proto = { path = "../xmtp_proto", features = ["proto_full", "grpc"] }
xmtp_user_preferences = { path = "../xmtp_user_preferences" }
xmtp_v2 = { path = "../xmtp_v2" }

tracing-subscriber = { version = "0.3", features = ["env-filter"] }
# NOTE: A regression in openssl-sys exists where libatomic is dynamically linked
# for i686-linux-android targets. https://github.com/sfackler/rust-openssl/issues/2163
#
Expand All @@ -46,6 +47,7 @@ tempfile = "3.5.0"
tokio = { version = "1.28.1", features = ["full"] }
tokio-test = "0.4"
uniffi = { version = "0.27.2", features = ["bindgen-tests"] }
tracing-subscriber = "0.3"
uuid = { version = "1.9", features = ["v4", "fast-rng" ] }

# NOTE: The release profile reduces bundle size from 230M to 41M - may have performance impliciations
Expand Down
Loading

0 comments on commit 79b6c7b

Please sign in to comment.