Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream-management: Implement requesting ACKs #1054

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

stream-management: Implement requesting ACKs #1054

wants to merge 42 commits into from
+547 −14

Conversation

sonnyp
Copy link
Member

@sonnyp sonnyp commented Jan 15, 2025

See #1005

singpolyma and others added 30 commits January 7, 2025 12:01
@singpolyma
Implement stream management requesting ACKs
c4d4bb8 
Queue outgoing stanzas and periodically request ACK.  Remove from the
queue anything ack'd and notify of the ack so apps can know the stanza
has for sure sent.

On resume, anything not ack'd is re-sent.  On reconnect, anything not
ack'd notify of the failure to send this stanza so apps can know the
stanza failed.

Even when there is no traffic, send an <r/> at least every 5 minutes to check the
connection.  If there is no inbound traffic (such as an <a/>) within
timeout (default 60 seconds) then consider the connection disconnected.
@sonnyp
Emit events on streamManagement object as suggested on #1005 (review)
6fa3127
@sonnyp
Remove unecessary conditions to clearTimeout
710b167
@sonnyp
prefer early return
ce30e8b
@singpolyma
No more clone
7ef1d8d 
Store the stamp seperately in the queue and then add it the first time
we retry.  Saves some work and a dependency.
@singpolyma
Throw Error not string
d76e479
@singpolyma
Catch any disconnect failure
69d0752
@singpolyma
Reformat this line
0190cb6
@singpolyma
Make more timeouts configurable
b2bf99c
@singpolyma
Test failure with something in queue seperately
0f79b3b
@singpolyma
Document events in readme
efad5c1
@singpolyma
Fix comment position
8cb8dff
@singpolyma
e2e test for stream management
8c408ef
@singpolyma
Use sendMany
43a2d69
@singpolyma
Change test name
97e8d28
@singpolyma
Split up resumed test
f076fd1
@singpolyma
Teardown on disconnect
f6e15ba
@singpolyma
Use promise helper
2209036
@singpolyma
e2e test for fail event when offline
c66696c
@singpolyma
e2e test for stanza retry
bb3998a
@singpolyma
e2e test auto reconnect
4736120 
Needs to use force-disconnect especially if we emulate an issue using pause
@sonnyp
better docs
b5eb66b
@sonnyp
extract fn to root
74b7f0b
@sonnyp
connection: Fix race condition when socket closes after timeout (#1048)
4a06393
@sonnyp
connection: Rename disconect() to _closeSocket()
d865571 
Users keep using it expecting it to be a public method even though it is not documented

* #1013
* b25e478
* #974

I guess that's fair, I'll create a new `disconnect` method that is safe to use.
@sonnyp
connection: Rename close() to _closeStream()
3177969 
See 2877a7b
@sonnyp
connection: Make disconnect a public function
96be425 
See
* 2877a7b
* 31bb31c
@sonnyp
Simplify status checks
a8298f7
@sonnyp
reconnect: Simplify code
9e2ff4b
@sonnyp
fast: Fix configurable saveToken and fetchToken (#1049)
aa6b3c1
sonnyp added 11 commits January 15, 2025 13:12
@sonnyp
Remove bundlesize (#1050)
bfef115
@sonnyp
events: Add helpers for event listeners (#1051)
d1790a2 
* Simplify code
* Support EventTarget and EventEmitter
@sonnyp
websocket: Remove ws dependency (#1052)
f932be3 
And improve `sendMany` for WebSocket
@sonnyp
tls: Use listeners()
fb5b799
@sonnyp
Various code improvements (#1053)
2d6e46f
@sonnyp
client: Do not allow PLAIN on insecure connection
a738c4a 
Also add connection.isSecure() method

Fixes #1040
@sonnyp
Replace socket.isSecure with socket.secure
407da51 
This helps in case the socket is proxied (eg WebWorker)
@sonnyp
Bump ltx
44ae9c9
@sonnyp
fast: Emit error events on entity
9cb0556 
At least on the web, emitting an error on fast will stop processing.
Unless there is an error event listener on it but adding error listener on all "plugins" is a bit cumbersome.
So let's always emit errors on entity instead.
@sonnyp
client: pass all arguments to credentials function
ced2057
@sonnyp
we dont need forceReconnect or socket.destory anymore
8935336
@sonnyp sonnyp mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonnyp @singpolyma