Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mkAbsolutePath in doAppend (XMonad.Prompt.AppendFile) #744

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

geekosaur
Copy link
Contributor

Description

Enhance mkAbsolutePath to support environment variables, then use it in XMonad.Prompt.AppendFile's doAppend so filespecs like ~/NOTES and $HOME/file.txt are supported.

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: manually tested in ghci

  • I updated the CHANGES.md file

@geekosaur
Copy link
Contributor Author

  1. Should I add this to CHANGES?
  2. Should I split this in two by the two commits?

Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should I add this to CHANGES?

Yes please (both changes, I would say)

  1. Should I split this in two by the two commits?

I think it works as two commits, as it's really to different things we're doing here, but if you'd prefer one commit that's fine as well

XMonad/Prelude.hs Show resolved Hide resolved
@geekosaur
Copy link
Contributor Author

I actually meant making a separate PR for each commit, as each addresses a different issue.

@slotThe
Copy link
Member

slotThe commented Aug 18, 2022

Oh right. I don't think that's necessary; I think we tend to think in commits more than PRs anyways

geekosaur added a commit to geekosaur/xmonad-contrib that referenced this pull request Aug 20, 2022
If you want more general support, comment on PR xmonad#744.
@geekosaur
Copy link
Contributor Author

That most recent push is just a rebase.

@slotThe slotThe merged commit 2ae1c86 into xmonad:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants