Skip to content

Commit

Permalink
Merge pull request #282 from anthraxx/fixup/prompt-fuzzymatch
Browse files Browse the repository at this point in the history
XMonad.Prompt sorter for FuzzyMatch
  • Loading branch information
LSLeary authored Oct 17, 2018
2 parents 81a9808 + 6dcc36c commit 2045243
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@
* `XMonad.Actions.MessageHandling`
Refresh-performing functions updated to better reflect the new `sendMessage`.

* `XMonad.Prompt`

Added `sorter` to `XPConfig` used to sort the possible completions by how
well they match the search string (example: `XMonad.Prompt.FuzzyMatch`).


## 0.14

### Breaking Changes
Expand Down
11 changes: 9 additions & 2 deletions XMonad/Prompt.hs
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ data XPConfig =
, searchPredicate :: String -> String -> Bool
-- ^ Given the typed string and a possible
-- completion, is the completion valid?
, sorter :: String -> [String] -> [String]
-- ^ Used to sort the possible completions by how well they
-- match the search string (see X.P.FuzzyMatch for an
-- example).
}

data XPType = forall p . XPrompt p => XPT p
Expand Down Expand Up @@ -268,6 +272,7 @@ instance Default XPConfig where
, showCompletionOnTab = False
, searchPredicate = isPrefixOf
, alwaysHighlight = False
, sorter = const id
}
{-# DEPRECATED defaultXPConfig "Use def (from Data.Default, and re-exported from XMonad.Prompt) instead." #-}
defaultXPConfig = def
Expand Down Expand Up @@ -956,8 +961,10 @@ getCompletionFunction st = case operationMode st of
getCompletions :: XP [String]
getCompletions = do
s <- get
io $ getCompletionFunction s (commandToComplete (currentXPMode s) (command s))
`E.catch` \(SomeException _) -> return []
let q = commandToComplete (currentXPMode s) (command s)
compl = getCompletionFunction s
srt = sorter (config s)
io $ (srt q <$> compl q) `E.catch` \(SomeException _) -> return []

setComplWin :: Window -> ComplWindowDim -> XP ()
setComplWin w wi =
Expand Down
10 changes: 5 additions & 5 deletions XMonad/Prompt/FuzzyMatch.hs
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,19 @@ import Data.List
-- 11. "FastSPR" is ranked before "FasterSPR" because its match starts at
-- position 5 while the match in "FasterSPR" starts at position 7.
--
-- To use these functions in an XPrompt, for example, for windowPromptGoto:
-- To use these functions in an XPrompt, for example, for windowPrompt:
--
-- > import XMonad.Prompt
-- > import XMonad.Prompt.Window ( windowPromptGoto )
-- > import XMonad.Prompt.Window ( windowPrompt )
-- > import XMonad.Prompt.FuzzyMatch
-- >
-- > myXPConfig = def { searchPredicate = fuzzyMatch
-- , sorter = fuzzySort
-- }
-- > , sorter = fuzzySort
-- > }
--
-- then add this to your keys definition:
--
-- > , ((modm .|. shiftMask, xK_g), windowPromptGoto myXPConfig)
-- > , ((modm .|. shiftMask, xK_g), windowPrompt myXPConfig Goto allWindows)
--
-- For detailed instructions on editing the key bindings, see
-- "Xmonad.Doc.Extending#Editing_key_bindings".
Expand Down

0 comments on commit 2045243

Please sign in to comment.