Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django testing. #258

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Update Django testing. #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af2c8c6
Fix typo in tests/django_test.py.
felixxm Oct 19, 2021
97fc4a7
Update Django testing.
felixxm Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/django_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def setUp(self):
settings.INSTALLED_APPS # load settings on first access
settings.DATABASES['default'] = {}
settings.DATABASES['default']['NAME'] = path.join(
self.tmpdir, 'db.sqlilte3')
self.tmpdir, 'db.sqlite3')
# this goes around the "settings already loaded" issue.
self.override = UserSettingsHolder(settings._wrapped)
settings._wrapped = self.override
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ deps =
coverage
codecov>=1.4.0
coveralls
djangolts,pytest: django>=1.11.0,<1.12.0
djangocurr: django>=2.2.0
djangolts,pytest: django>=3.2.0,<4.0.0
djangocurr: django>=4.0a1,<4.1.0
Comment on lines +21 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use ~ notation and use 3.2.9 that add support for python3.10:

Suggested change
djangolts,pytest: django>=3.2.0,<4.0.0
djangocurr: django>=4.0a1,<4.1.0
djangolts,pytest: django~=3.2.9
djangocurr: django>=4.0rc1,<4.1.0

pytest: pytest
lxml>=3.6.0
commands =
Expand Down