Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eyelight shader and use it as default #1

Closed
lachsen opened this issue Feb 28, 2013 · 2 comments
Closed

Add eyelight shader and use it as default #1

lachsen opened this issue Feb 28, 2013 · 2 comments

Comments

@lachsen
Copy link
Contributor

lachsen commented Feb 28, 2013

I think an eyelight shader as default shader would be nice.
It makes the 3D shape more recognizable than simple flat shading or phong shading without light sources.
This is especially useful for first steps with XML3D.

@ksons ksons added this to the Release 5.0 milestone Feb 3, 2015
@ksons
Copy link

ksons commented Feb 3, 2015

As dicussed, we won't use eyelight shader due to its integrated light which does not appear in the scene description. Instead we'll add another useful defualt shader (instead of error shader as it is right now).

@ksons ksons closed this as completed Feb 3, 2015
@ksons ksons reopened this Feb 3, 2015
@csvurt
Copy link
Contributor

csvurt commented Apr 2, 2015

This issue has been subsumed under #109

@csvurt csvurt closed this as completed Apr 2, 2015
@ksons ksons removed this from the Release 5.0 milestone Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants