Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update find_matlab and add find_matlab_runtime #2782

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Update find_matlab and add find_matlab_runtime #2782

merged 4 commits into from
Sep 6, 2022

Conversation

WubiCookie
Copy link
Contributor

No description provided.

waruqi
waruqi reviewed Sep 5, 2022
View reviewed changes
xmake/modules/detect/sdks/find_matlab_runtime.lua
-- find lib
for _, value in pairs(result.linkdirs) do
local dirbasename = path.basename(value)
result.links[dirbasename] = path.join(value, "*")
Copy link
Member

@waruqi waruqi Sep 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add path and * to links?

waruqi
waruqi reviewed Sep 5, 2022
View reviewed changes
xmake/modules/detect/sdks/find_matlab.lua
r2012b = "8.0",
r2012a = "7.17",
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move them to detect/sdks/matlab.lua

then use matlab.versions() to get them

@waruqi waruqi merged commit 400b22b into xmake-io:dev Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WubiCookie @waruqi @charlesseizilles