Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency not installed when using --group #4882

Closed
charlesseizilles opened this issue Mar 26, 2024 · 2 comments
Closed

Dependency not installed when using --group #4882

charlesseizilles opened this issue Mar 26, 2024 · 2 comments
Labels
Milestone

Comments

@charlesseizilles
Copy link
Contributor

Xmake Version

2.8.9

Operating System Version and Architecture

Windows 10 version 22H2

Describe Bug

Dependencies are not installed when I call xmake i -g testGroup, but they are when individual targets are specified.

With this file:

target("commonLib")
    set_kind("static")
    add_files("source.cpp")
    on_install(function()
        print("on_install from commonLib!")
    end)

target("testA")
    add_deps("commonLib")
    add_files("main.cpp")
    set_group("testGroup")
    on_install(function()
        print("on_install from testA!")
    end)

target("testB")
    add_deps("commonLib")
    add_files("main.cpp")
    set_group("testGroup")
    on_install(function()
        print("on_install from testB!")
    end)
> xmake install -g testGroup
on_install from testA!
on_install from testB!
install ok!
> xmake install testA
on_install from commonLib!
on_install from testA!
install ok!

commonLib should have been installed on the first command.

Expected Behavior

Dependencies should always be installed

Project Configuration

xmake.zip

Additional Information and Error Logs

.

waruqi added a commit that referenced this issue Mar 27, 2024
@waruqi waruqi added this to the v2.9.1 milestone Mar 27, 2024
waruqi added a commit that referenced this issue Mar 27, 2024
Improve to install with group #4882
@waruqi
Copy link
Member

waruqi commented Mar 27, 2024

try it again.

xmake update -s dev

#4885

@charlesseizilles
Copy link
Contributor Author

It works fine now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants