add rightonly jsondiff syntax #60
Conversation
jsondiff/symbols.py
Outdated
| @@ -12,6 +12,10 @@ def __str__(self): | |||
| def __eq__(self, other): | |||
| return self.label == other.label | |||
|
|
|||
| def __hash__(self): | |||
There was a problem hiding this comment.
Given how eq works, I think this should be
def __hash__(self):
return hash(self.label)
| @@ -8,6 +9,15 @@ | |||
| from hypothesis import given, settings, strategies | |||
|
|
|||
|
|
|||
| logging.basicConfig( | |||
There was a problem hiding this comment.
This seems like debugging code. Did you intend to leave this in here?
There was a problem hiding this comment.
It's convenient to add some log during test.
|
IntuitiveSyntax is interesting! If you're still working on this it would be really cool to have as an option. Maybe a followup commit to strip this PR down to just that feature? |
|
After testing this some more I'm questioning the name Some ideas:
|
|
In my senario, I only what to know what field has changed. And check if the newest value is reasonable. |
|
Those sound reasonable to me! +1 for |
|
Can you edit the title to reflect the latest changes and add a PR description explaining your changes? That will make it easier to understand months from now. |
ramwin
changed the title
|
@corytodd I have updated the pull request title and added a PR description. Thank you for your advice. |
|
Hello, do you intend to make a release soon with this PR? |
I some senario, we often compare old value and new value and check if the newer value is reasonabel. So the rightonly syntax will compute the dicfference and keep the later one compared to CompactJsonDiffSyntax