chore: ignore hyper dependency update #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 75.55% 75.37% -0.18%
==========================================
Files 180 182 +2
Lines 26938 26995 +57
Branches 26938 26995 +57
==========================================
- Hits 20353 20348 -5
- Misses 5366 5384 +18
- Partials 1219 1263 +44 ☔ View full report in Codecov by Sentry. |
rogercloud
reviewed
Mar 25, 2024
Phoenix500526
force-pushed
the
dependencies/hyper
branch
from
99cd95d to
037596d
Compare
|
@Phoenix500526 Convert your pr to draft since CI failed |
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
dependencies/hyper
branch
from
037596d to
dbed074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Prevent automatic upgrade of hyper from 0.14.28 to 1.0.0, as tonic depends on deprecated data structures, such as
AddrStreamandAddrIncoming.FYI: hyperium/hyper#2850
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)