Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s Schema Matcher #307

Merged
merged 9 commits into from
Jan 16, 2024
Merged

K8s Schema Matcher #307

merged 9 commits into from
Jan 16, 2024

Conversation

MarkintoshZ
Copy link
Collaborator

This PR will merge the k8s core resource schema matching component of the input model refactor task (#302, #296).

Change summary:

  • Implemented K8sSchemaMatcher class
  • Applied property-name-based heuristic on ranking matched schema
  • Improved schema matching heuristic based on property names used in OpenAPI schema
  • Added test cases for K8sSchemaMatcher
  • Matched descendants of matched schemas
  • Renamed K8s dict and list schema class
  • Fixed and improved type hints

@MarkintoshZ MarkintoshZ requested a review from tylergu January 16, 2024 06:16
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  acto/input
  k8s_schemas.py 76-83, 96, 103, 113, 123, 130, 133, 155, 158, 177, 183, 186, 193, 196, 203, 206, 214, 301-302, 310, 316, 320, 405, 414-457
Project Total  

This report was generated by python-coverage-comment-action

@tylergu tylergu merged commit 9c942b5 into main Jan 16, 2024
4 checks passed
@MarkintoshZ MarkintoshZ mentioned this pull request Jan 19, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants