Skip to content

Commit

Permalink
Fix Kubernetes Engine test
Browse files Browse the repository at this point in the history
Signed-off-by: Tyler Gu <[email protected]>
  • Loading branch information
tylergu committed Sep 5, 2024
1 parent d7698c1 commit 87a6750
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion acto/kubernetes_engine/minikube.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def create_cluster(self, name: str, kubeconfig: str):
else:
raise RuntimeError("Missing kubeconfig for minikube create")

cmd.extend(["--nodes", str(self.num_nodes)])
cmd.extend(["--nodes", str(self.num_nodes + 1)])

if self._k8s_version != "":
cmd.extend(["--kubernetes-version", str(self._k8s_version)])
Expand Down
4 changes: 2 additions & 2 deletions test/integration_tests/test_kubernetes_engines.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from acto.kubernetes_engine.kind import Kind
from acto.kubernetes_engine.minikube import Minikube

testcases = [("kind", 3, "v1.27.3")]
testcases = [("kind", 4, "v1.27.3")]


@pytest.mark.kubernetes_engine
Expand All @@ -34,7 +34,7 @@ def test_kubernetes_engines(cluster_type: str, num_nodes, version):
cluster_instance.create_cluster(name, config_path)

node_list = cluster_instance.get_node_list(name)
assert len(node_list) == num_nodes
assert len(node_list) == num_nodes + 1

cluster_instance.delete_cluster(name, config_path)
with pytest.raises(RuntimeError):
Expand Down

0 comments on commit 87a6750

Please sign in to comment.