Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling choices or defects? #44

Open
philippemerle opened this issue Nov 5, 2021 · 6 comments · Fixed by #47
Open

Modeling choices or defects? #44

philippemerle opened this issue Nov 5, 2021 · 6 comments · Fixed by #47
Labels
TOSCA This has to do something with TOSCA standard

Comments

@philippemerle
Copy link
Contributor

I used our tosca toolbox to automatically generate visual diagrams in order to study modeling choices and identify modeling defects in TOSCA types and topologies of all xOpera examples.

Following is a UML2 component diagram representing the TOSCA topology of the cloud/aws/thumbnail-generator-with-vm example:

xopera-examples-cloud-aws-thumbnail-generator-with-vm-service-uml2-component-diagram2

Following is a proprietary diagram representing the same topology (only node templates are represented):

xopera-examples-cloud-aws-thumbnail-generator-with-vm-service

On both diagrams, we could observe that:

  • some node templates (bucket_notification, ec2_docker, ec2_web_app, bucket_out, bucket_in, prerequisites) have no business specific capabilities, except for the standard feature capability.
  • some node templates (lambda, lambda_role, ec2_keypair, vpc_subnet, ec2_role) have only one business specific capability, except for the standard feature capability. But these business capabilities are the target of no relationship.
  • No business specific relationship templates are present in this example, except for both standard DependsOn and HostedOn relationships.

Are those modeling choices or modeling defects?

@anzoman
Copy link
Contributor

anzoman commented Nov 5, 2021

@philippemerle we developed this example to showcase the xOpera deployment on AWS and it seems that we focused more on the Ansible playbook executors within TOSCA interface operations. So, we tried to create a valid TOSCA structure, but if you see that there are some possible improvements or fixes for those modeling defects, you can express them here (also feel free to correct them yourself).

@anzoman anzoman added the TOSCA This has to do something with TOSCA standard label Nov 5, 2021
@philippemerle
Copy link
Contributor Author

I will propose you (asap) some improvements fixing those modeling defects.
Moreover these improvements should be reuseable for all other cloud examples.

@philippemerle
Copy link
Contributor Author

I see another different modeling defect in two other examples.

Following is a UML2 component diagram representing the tosca/policy-triggers/service.yaml topology:

xopera-examples-tosca-policy-triggers-service-uml2-component-diagram1

This diagram shows that the AutoScale policy targets the openstack_vm node template.
But we also see that both ScaleDown and ScaleUp policies target no node template.
This should be a modeling defect: ScaleDown and ScaleUp policies should target openstack_vm too.

Following is a UML2 component diagram representing the misc/scaling/service.yaml topology:

xopera-examples-misc-scaling-service-uml2-component-diagram1

Here we see that both ScaleDown and ScaleUp policies target no node template.
They both should target some node templates.

@anzoman
Copy link
Contributor

anzoman commented Nov 8, 2021

Aha, yes @philippemerle thanks for finding another modeling defect.

@philippemerle
Copy link
Contributor Author

@anzoman could this issue reopened as most of modeling defects were not fixed?

@anzoman
Copy link
Contributor

anzoman commented Nov 10, 2021

Sure, let's reopen this.

@anzoman anzoman reopened this Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOSCA This has to do something with TOSCA standard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants