Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

通过阅读源码提高你的 JavaScript 水平 #6179

Merged
merged 12 commits into from
Jul 27, 2019
Merged

通过阅读源码提高你的 JavaScript 水平 #6179

merged 12 commits into from
Jul 27, 2019

Conversation

MarchYuanx
Copy link
Contributor

译文翻译完成，resolve #6152

@MarchYuanx
translation #1
dc81ea1 
translation #1
@MarchYuanx
transla #2
ea90df5 
transla #2
@MarchYuanx
translation #3
e85b258 
translation #3
@MarchYuanx
translation finished
42d6507 
translation finished
@MarchYuanx
change title
2702a15 
change title
@fanyijihua fanyijihua mentioned this pull request Jul 22, 2019
Closed
@leviding leviding changed the title 通过阅读源码提高您的 javascript 水平 通过阅读源码提高您的 JavaScript 水平 Jul 23, 2019
@imononoke
Copy link

申请校对。

@fanyijihua
Copy link
Collaborator

@imononoke 好的呢 🍺

@JaxNext
Copy link
Contributor

JaxNext commented Jul 23, 2019

认领校对。

@fanyijihua
Copy link
Collaborator

@baddyo 妥妥哒 🍻

JaxNext
JaxNext reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@JaxNext JaxNext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完成。@MarchYuanx 译者辛苦了。

整体翻译得不错，前半部分语言平实准确，很到位，后半部分略显潦草。

TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
@MarchYuanx
校对修改_1
c28e350 
第一次校对修改
@MarchYuanx
Copy link
Contributor Author

@baddyo 十分感谢！ 确实，因为没有把握好时间节奏，导致后半部分十分浮躁，各种格式错误。汗颜，之后会多多注意，本篇会重阅一次。再次感谢！

@MarchYuanx
校对修改_2
a3a1a58 
校对修改_2
@MarchYuanx MarchYuanx changed the title 通过阅读源码提高您的 JavaScript 水平 通过阅读源码提高你的 JavaScript 水平 Jul 23, 2019
@MarchYuanx
校对修改_3
0b80e20 
校对修改_3
@leviding leviding added the Tag 一次校对修改完成 label Jul 24, 2019
@MarchYuanx
校对修改_4
0a9bbab 
校对修改_4
@leviding
Copy link
Member

@imononoke 请抓紧时间校对哈，超期了

@imononoke
Copy link

@leviding 好的，抱歉耽误时间了，现在校对。

@MarchYuanx
校对修改_5
a208920 
校对修改_5
imononoke
imononoke reviewed Jul 26, 2019
View reviewed changes
Copy link

@imononoke imononoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarchYuanx 总体翻译得挺好的~
@leviding 初步校对完成~

TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
TODO1/javascript-knowledge-reading-source-code.md Outdated Show resolved Hide resolved
@leviding leviding added enhancement 等待译者修改 and removed 正在校对 Tag 一次校对修改完成 labels Jul 26, 2019
@MarchYuanx
校对修改_6
d992da8 
校对修改_6
@MarchYuanx
Copy link
Contributor Author

校对修改完成 @leviding

@leviding leviding added 标注 待管理员 Review and removed enhancement 等待译者修改 labels Jul 27, 2019
@leviding leviding merged commit b46ba2e into xitu:master Jul 27, 2019
@leviding
Copy link
Member

@MarchYuanx 已经 merge 啦~ 快快麻溜发布到 掘金，然后在本 PR 下回复文章链接，方便及时添加积分哟。

掘金翻译计划有自己的知乎专栏，你也可以投稿哈，推荐使用一个好用的插件。
专栏地址：https://zhuanlan.zhihu.com/juejinfanyi

@leviding leviding added 翻译完成 and removed 标注 待管理员 Review labels Jul 27, 2019
@MarchYuanx
Copy link
Contributor Author

@leviding 已经发布在掘金 感谢各位
https://juejin.im/post/5d3c56c26fb9a07efd475414

pingren pushed a commit to pingren/gold-miner that referenced this pull request Jul 31, 2019
@MarchYuanx
通过阅读源码提高你的 JavaScript 水平 (xitu#6179)
0c3be55 
* translation #1

translation #1

* transla #2

transla #2

* translation #3

translation #3

* translation finished

translation finished

* change title

change title

* 校对修改_1

第一次校对修改

* 校对修改_2

校对修改_2

* 校对修改_3

校对修改_3

* 校对修改_4

校对修改_4

* 校对修改_5

校对修改_5

* 校对修改_6

校对修改_6

* Update javascript-knowledge-reading-source-code.md
pingren pushed a commit to pingren/gold-miner that referenced this pull request Jul 31, 2019
Revert "通过阅读源码提高你的 JavaScript 水平 (xitu#6179)"
9b84245 
This reverts commit 0c3be55.
pingren pushed a commit to pingren/gold-miner that referenced this pull request Jul 31, 2019
Revert "通过阅读源码提高你的 JavaScript 水平 (xitu#6179)"
9d44d02 
This reverts commit 0c3be55.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaxNext JaxNext JaxNext left review comments

@imononoke imononoke imononoke left review comments

@leviding leviding leviding approved these changes

Assignees
No one assigned
Labels
前端 翻译完成
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

通过阅读源码提高您的 JavaScript 水平
5 participants
@MarchYuanx @imononoke @fanyijihua @JaxNext @leviding