Proposal: remove all try-catch style codes #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to follow up #395, all existing
recover
calls are doing Java/C++ try-catch style error handling, which makes things hard to debug due to lack of call stack.For example, #452 reports problem without any source file and line numbers, after removing all recover calls, I got:
which makes it super easy to fix.
This PR may cause panic for those who depend on parquet-go in near future, but we can collect all those panic cases and fix them by adding extra check on incoming data/parameters.
I used patched version with my personal project, it just works without any problems.