simplify function

Signed-off-by: xinyual <[email protected]>
xinyual · Nov 21, 2024 · f53a656 · f53a656
1 parent 9c831ba
commit f53a656
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/plugin/src/main/java/org/opensearch/ml/action/models/DeleteModelTransportAction.java b/plugin/src/main/java/org/opensearch/ml/action/models/DeleteModelTransportAction.java
@@ -533,18 +533,16 @@ private Boolean searchThroughConfig(Object searchCandidate, String candidateId)
 
     private String formatAgentErrorMessage(SearchHit[] hits) {
         boolean isHidden = false;
+        List<String> agentIds = new ArrayList<>();
         for (SearchHit hit : hits) {
             Map<String, Object> sourceAsMap = hit.getSourceAsMap();
             isHidden = isHidden || Boolean.parseBoolean((String) sourceAsMap.getOrDefault(MLAgent.IS_HIDDEN_FIELD, false));
+            agentIds.add(hit.getId());
         }
         if (isHidden) {
             return String
                 .format(Locale.ROOT, "%d agents are still using this model, please delete or update the agents first", hits.length);
         }
-        List<String> agentIds = new ArrayList<>();
-        for (SearchHit hit : hits) {
-            agentIds.add(hit.getId());
-        }
         return String
             .format(
                 Locale.ROOT,