use ARG instead of ENV to silence apt commands

xing · Feb 9, 2024 · 76a9951 · 76a9951
1 parent d3c1f0f
commit 76a9951
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/fpm/fry/docker_file.rb b/lib/fpm/fry/docker_file.rb
@@ -140,7 +140,7 @@ def dockerfile
             if options[:update]
               update = 'apt-get update && '
             end
-            df[:dependencies] << "ENV DEBIAN_FRONTEND=noninteractive"
+            df[:dependencies] << "ARG DEBIAN_FRONTEND=noninteractive"
             df[:dependencies] << "RUN #{update}apt-get install --yes #{Shellwords.join(build_dependencies)}"
           when 'redhat'
             df[:dependencies] << "RUN yum -y install #{Shellwords.join(build_dependencies)}"

diff --git a/spec/docker_file_spec.rb b/spec/docker_file_spec.rb
@@ -96,7 +96,7 @@ def self.included(base)
           expect(subject.dockerfile).to eq(<<SHELL)
 FROM <base>
 WORKDIR /tmp/build
-ENV DEBIAN_FRONTEND=noninteractive
+ARG DEBIAN_FRONTEND=noninteractive
 RUN apt-get install --yes arg blub foo
 COPY .build.sh /tmp/build/
 CMD /tmp/build/.build.sh
@@ -151,7 +151,7 @@ def self.included(base)
           expect(subject.dockerfile).to eq(<<SHELL)
 FROM <base>
 WORKDIR /tmp/build
-ENV DEBIAN_FRONTEND=noninteractive
+ARG DEBIAN_FRONTEND=noninteractive
 RUN apt-get install --yes D a b e\\=1.0.0
 COPY .build.sh /tmp/build/
 CMD /tmp/build/.build.sh
@@ -176,7 +176,7 @@ def self.included(base)
           expect(subject.dockerfile).to eq(<<SHELL)
 FROM <base>
 WORKDIR /tmp/build
-ENV DEBIAN_FRONTEND=noninteractive
+ARG DEBIAN_FRONTEND=noninteractive
 RUN apt-get install --yes a
 COPY .build.sh /tmp/build/
 CMD /tmp/build/.build.sh
@@ -239,7 +239,7 @@ def self.included(base)
 FROM <base>
 WORKDIR /tmp/build
 probe a
-ENV DEBIAN_FRONTEND=noninteractive
+ARG DEBIAN_FRONTEND=noninteractive
 RUN apt-get install --yes a
 probe b
 COPY .build.sh /tmp/build/