Feature: cache busting #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for page resource or global resource (gohugoio/hugo#12245) * Add fingerprint to the resources * Preserve original hugo-easy-gallery logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thank you for your great template!
I'm currently setting up caching. It might be a good idea to implement cache busting.
We could add a hash to all JS and CSS assets and allow them to be cached forever, and disable caching for HTML.
Here's my approach in more detail:
I got the latest built-in figure shortcode that makes use of page resources. A fingerprint is added to page resources. Other links are not changed. The original hugo-easy-gallery logic around "src", "link" and "thumb" parameters is preserved.
I also updated the full config with an example of Cache-Control settings.
Would be glad to hear your thoughts.