Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further refinements to ViewManager #3850

Merged
merged 32 commits into from
Dec 13, 2024
Merged

Further refinements to ViewManager #3850

merged 32 commits into from
Dec 13, 2024

Conversation

amcclain
Copy link
Member

@amcclain amcclain commented Dec 11, 2024 •
edited
Loading

TODOs:

  • When deleting a view that is the active view, we should auto-select default / first available view. Currently the deleted view stays in place.
  • Auto-save menu option does not disable when global view selected if already on/enabled
  • When saving-as a global or shared view (not one of your own views), don't prepend "Copy of" to the suggested name.
    • Maybe never prepend? We could use unmodified name if copying global\shared, blank out name if your own
  • refresh button within mgr dialog does not trigger full refresh from server

Nice-to-haves

  • Option within manager dialog to saveAs selected view
  • Warn within mgr on sel change if there are unsaved changes to prev view

lbwexler and others added 30 commits December 8, 2024 09:33
@lbwexler
Checkpoint
66a5d53
@lbwexler
Checkpoint
21572f9
@lbwexler
Checkpoint
6fcf7d0
@lbwexler
Checkpoint
c8102e6
@lbwexler
Checkpoint
d30c897
@lbwexler
Checkpoint
22d6aee
@lbwexler
Checkpoint
b1e9328
@lbwexler
Fix Sorting
25dcca2
@lbwexler
Checkpoint
b274fdb
@lbwexler
Checkpoint
905a979
@amcclain
Merge branch 'develop' into pinningPlus
3a6eb03
@amcclain
ViewMenu fix
12be585
@amcclain
View management tweaks
c3a9105 
- Add form button to toggle pinning
- Make RO form look a bit nicer
- Tweak a few confirm messages
@lbwexler
Checkpoint
fec3036
@amcclain
Comment tweaks
67b84f5
@amcclain
Default settleTime to 1000ms
0fe7137
@amcclain
Tweak
9ca519f
@amcclain
Set fireImmediately on ViewPanelModel reaction
5c43cee
@amcclain
Inline help text in mgr dialog
a20355b
@amcclain
Tweak
3810464
@amcclain
Add "activate + close" button to mgr dialog
659d5b5
@amcclain
Tweak
84abb6f
@lbwexler
Tweak to read-only view of form
061282a
@lbwexler
Always show badge
4cc3e61
@lbwexler
Names need only be unique in your own namespace
a42ee95
@lbwexler
Auto-save disabled during impersonation
893c5f9
@amcclain
Confirm message tweaks
96110be
@amcclain
Further tweaks
7bb89ef
@amcclain
Confirm message tweaks
5eb0979
@amcclain
When saving copy of view, use same name if no conflict
76a9044 
- Easier saving of a global/shared views without need to prepend (and then have user remove) "Copy of"
- Copy description - maybe it's useful
@lbwexler lbwexler marked this pull request as ready for review December 13, 2024 19:34
@lbwexler lbwexler merged commit f3a0b46 into develop Dec 13, 2024
2 checks passed
@lbwexler lbwexler deleted the pinningPlus branch December 13, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcclain @lbwexler @febbraiod