Harden views #3845
Merged
Harden views #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghsolomon
reviewed
Dec 5, 2024
| } | ||
|
|
||
| constructor(info: ViewInfo, value: Partial<T>) { | ||
| constructor(info: ViewInfo, value: Partial<T>, model: ViewManagerModel) { |
There was a problem hiding this comment.
Believe this should be model: ViewManagerModel<T>, but also curious why the backpointer to the model. Looks like just for the type and typedName.
ghsolomon
reviewed
Dec 5, 2024
| } | ||
|
|
||
| static createDefault<T>(): View<T> { | ||
| return new View(null, {}); | ||
| static createDefault<T>(model: ViewManagerModel): View<T> { |
There was a problem hiding this comment.
See comment in constructor re: generic ViewManagerModel type
ghsolomon
reviewed
Dec 5, 2024
| get token(): string { | ||
| return this.info?.token ?? null; | ||
| get typedName(): string { | ||
| return `${this.model.typeDisplayName} '${this.name}'`; | ||
| } | ||
|
|
||
| static fromBlob<T>(blob: JsonBlob, model: ViewManagerModel): View<T> { |
There was a problem hiding this comment.
See comment in constructor re: generic ViewManagerModel type
ghsolomon
reviewed
Dec 5, 2024
| @@ -33,24 +47,25 @@ export class View<T extends PlainObject = PlainObject> { | |||
| return this.info?.lastUpdated ?? null; | |||
| } | |||
|
|
|||
| get token(): string { | |||
| return this.info?.token ?? null; | |||
| get typedName(): string { | |||
There was a problem hiding this comment.
Wonder if it would make sense to have a getTypedName helper that takes a view and a model or view and a type rather than having it be a top-level property on view itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.