Skip to content

Commit

Permalink
Fix mobile TabContainer switcher sizing and position (#3874)
Browse files Browse the repository at this point in the history
  • Loading branch information
TomTirapani authored Dec 27, 2024
1 parent 24c7fbd commit 1ee8cf4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* `TreeMap` and `SplitTreeMap` are now cross-platform and can be used in mobile applications.
Their import paths have changed from `@xh/hoist/desktop/cmp/treemap` to `@xh/hoist/cmp/treemap`.
* The `RefreshButton` `model` prop has been renamed `target` for clarity and consistency.

### 🎁 New Features

* Major Improvements to ViewManager component
Expand All @@ -27,6 +28,11 @@
* Added support for `AuthZeroClientConfig.audience` to support improved configuration of Auth0 OAuth
clients requesting access tokens, covering cases when third-party cookies are blocked.

### 🐞 Bug Fixes

* Fixed sizing and position of mobile `TabContainer` switcher, particularly when the switcher is
positioned with `top` orientation.

### ⚙️ Technical

* Added explicit `devDependencies` and `resolutions` blocks for `@types/react[-dom]` at v18.x.
Expand Down
7 changes: 3 additions & 4 deletions mobile/cmp/tab/impl/Tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
}

.xh-tab-container {
// Override Onsen's tabbar height CSS var
--tabbar-height: var(--xh-tbar-min-size-px);

position: relative;
flex: auto;

Expand All @@ -49,10 +52,6 @@
line-height: var(--xh-tbar-min-size-px);
color: var(--xh-text-color);
}

&__content {
bottom: var(--xh-tbar-min-size-px);
}
}

// Tab visibility is managed via TabContainerModel.renderMode, rather than Onsen's internal state.
Expand Down

0 comments on commit 1ee8cf4

Please sign in to comment.