[clang codegen] Fix MS ABI detection of user-provided constructors. (l…

…lvm#90151)

In the context of determining whether a class counts as an "aggregate",
a constructor template counts as a user-provided constructor.

Fixes llvm#86384

(cherry picked from commit 3ab4ae9)

clang/docs/ReleaseNotes.rst

@@ -118,6 +118,12 @@ ABI Changes in This Version
   `-fms-compatibility-version=19.14` to imitate the MSVC 1914 mangling behavior.
   (GH#70899).
 
+- Fixed Microsoft calling convention for returning certain classes with a
+  templated constructor. If a class has a templated constructor, it should
+  be returned indirectly even if it meets all the other requirements for
+  returning a class in a register. This affects some uses of std::pair.
+  (#GH86384).
+
 AST Dumping Potentially Breaking Changes
 ----------------------------------------