Temporarily use Dask version constraint in CI #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 94.24% 94.41% +0.17%
==========================================
Files 3 3
Lines 226 215 -11
Branches 65 58 -7
==========================================
- Hits 213 203 -10
Misses 8 8
+ Partials 5 4 -1
Continue to review full report at Codecov.
|
|
This is great @jrbourbeau. Thanks so much for all your help around here! |
|
Yeah, no problem. Happy to help out where I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way to enable CI to start passing again in light of #27. Another option would have been to explicitly
xfailtest_histogram_shapewhen usingdask=2021.3.0. The approach here seems a little simpler to me, but I'm happy to update to something else if others prefer.