Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Windows arm64 support #511

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

imsudiproy
Copy link
Contributor

This PR adds support for windows arm64

@imsudiproy
Copy link
Contributor Author

Working on adding armv7 support.

@xerial
Copy link
Owner

xerial commented Sep 25, 2023

Thanks. Have you tested it on a real Windows arm64 machine (e.g., Surface Pro X)?

@imsudiproy
Copy link
Contributor Author

imsudiproy commented Sep 25, 2023

No, I don't have Windows arm64 machine. It is better to test it before merging.

@xerial
Copy link
Owner

xerial commented Sep 25, 2023

Ok. I'll check this PR by using my own one :) Give me some time

@imsudiproy
Copy link
Contributor Author

Okay, thanks. Till then I'll try to add support for armv7. Currently I am facing error related to vqtbl1q_u8.
The error suggests using vtbl1_u8 instead of vqtbl1q_u8. On searching about this, I got to know that in ARM NEON, vqtbl1q_u8 operates on 128-bit vectors, but we should use vtbl1_u8 for 64-bit vectors.

@xerial
Copy link
Owner

xerial commented Sep 26, 2023

Ok. Let's merge this PR first (I'll test it later), and create another PR for Windows + armv7.

@xerial xerial changed the title Feature: add windows arm64 support Feature: Add Windows arm64 support Sep 26, 2023
@xerial xerial merged commit ee96b64 into xerial:master Sep 26, 2023
3 checks passed
@xerial
Copy link
Owner

xerial commented Sep 26, 2023

@imsudiproy It seems this build was not using the right compilation parameters. Working on a fix at #518

@imsudiproy
Copy link
Contributor Author

@xerial Thank you for addressing the issue.

@xerial
Copy link
Owner

xerial commented Sep 27, 2023

With #518 and #520, I could run snappy-java in Windows on arm64 (My Surface Pro X)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants