Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readFrom ByteBuffer error #72

Merged
merged 1 commit into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ public int readFrom(byte[] src, int srcOffset, long destOffset, int length) {
* @return the number of bytes read
*/
public int readFrom(ByteBuffer src, long destOffset) {
if (src.remaining() + destOffset >= size())
if (src.remaining() + destOffset > size())
throw new BufferOverflowException();
int readLen = src.remaining();
ByteBuffer b = toDirectByteBuffer(destOffset, readLen);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,5 +205,12 @@ class LBufferTest extends LArraySpec {

}

"read from ByteBuffer" in {
val bytes = Array[Byte](1, 2, 3)
val byteBuffer = ByteBuffer.wrap(bytes)
val lbuffer = new LBuffer(3)
lbuffer.readFrom(byteBuffer, 0)
byteBuffer.array() === lbuffer.toArray
}
}
}