fix readFrom bytebuffer error (#72)

xerial · Nov 25, 2022 · 400d232 · 400d232
1 parent 6baebc6
commit 400d232
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/larray-buffer/src/main/java/xerial/larray/buffer/LBufferAPI.java b/larray-buffer/src/main/java/xerial/larray/buffer/LBufferAPI.java
@@ -383,7 +383,7 @@ public int readFrom(byte[] src, int srcOffset, long destOffset, int length) {
      * @return the number of bytes read
      */
     public int readFrom(ByteBuffer src, long destOffset) {
-        if (src.remaining() + destOffset >= size())
+        if (src.remaining() + destOffset > size())
             throw new BufferOverflowException();
         int readLen = src.remaining();
         ByteBuffer b = toDirectByteBuffer(destOffset, readLen);

diff --git a/larray-buffer/src/test/scala/xerial/larray/buffer/LBufferTest.scala b/larray-buffer/src/test/scala/xerial/larray/buffer/LBufferTest.scala
@@ -205,5 +205,12 @@ class LBufferTest extends LArraySpec {
 
     }
 
+    "read from ByteBuffer" in {
+      val bytes = Array[Byte](1, 2, 3)
+      val byteBuffer = ByteBuffer.wrap(bytes)
+      val lbuffer = new LBuffer(3)
+      lbuffer.readFrom(byteBuffer, 0)
+      byteBuffer.array() === lbuffer.toArray
+    }
   }
 }