Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload is never resolved when an empty array is passed in. #8

Closed

Conversation

joe-yeomans
Copy link

When an empty array is passed into the preload() function, the promise is never resolved. Changed the code so that is checks for an empty array.

Also might be a good idea to add a Prettier file into the project so the styling is consistent.

@Yann-prak
Copy link

Hi,

I'm not sure, but shouldn't it be input instead of loadImage? As loadImage is a function.

if (input.length === 0) {
   resolve();
   return;
}

@xerdnu
Copy link
Owner

xerdnu commented Aug 14, 2024

Unfortunately i messed up when adding the pull requests but this is added in the latest release.

Best regards 🚀

@xerdnu xerdnu closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants