feat: support onLoad, onError and fallbackSource #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerdnu
added a commit
that referenced
this pull request
Oct 31, 2023
|
Looks really good! I just made a minor adjustment to include the static asset as a last resort if both the primary and fallbackSource fails. Also made some updates to the documentation 😄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @xerdnu ,
This is just a small PR.
To support onLoad en onError callbacks. Might come in handy?
Also I've added a fallback source. Cause now the error image was hardcoded require.
Let me know what you think 👍