Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default CameraControl cursor style #522

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

Kurtil
Copy link
Contributor

@Kurtil Kurtil commented Jan 7, 2021

If "default" is added to the cursor style, the cursor style from parent DOM Elements won't be able to change the canvas cursor style.

If null (or "") is added instead, it removes the cursor style entry from the style attribute of the canvas element, letting cursor style cascading from parent elements.

@Kurtil
Copy link
Contributor Author

Kurtil commented Jan 7, 2021

Use case:

copy-cursor

It is not possible to display the "copy" cursor in this example if the "default" is set.

@xeolabs xeolabs merged commit e748338 into xeokit:master Jan 7, 2021
@xeolabs xeolabs changed the title Remove default cursor style. Remove default CameraControl cursor style Jan 14, 2021
@xeolabs xeolabs added this to the 1.6.0 milestone Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants