Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-textures]: implement a smart deferred flags update mechanism #1037

Merged
merged 1 commit into from
May 2, 2023

Conversation

tmarti
Copy link
Contributor

@tmarti tmarti commented May 2, 2023

If the number of updated per-object properties in a frame is less than a threshold, they will be updated directly.

If the number of updates is instead bigger than a threshold (by default 10), the ones above the threshold will be batched, and the batch flushed just before rendering the frame.

This completely solves #1033

If the number of updated per-object properties in a frame is less than a threshold, they will be updated directly.

If the number of updates is instead bigger than a threshold (by default 10), the ones above the threshold will be batched, and the batch flushed just before rendering the frame.

This completely solves xeokit#1033
@ghost
Copy link

ghost commented May 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@xeolabs xeolabs added this to the 2.4.0 milestone May 2, 2023
@xeolabs xeolabs merged commit 917b4a3 into xeokit:master May 2, 2023
@xeolabs xeolabs added the enhancement New feature or request label May 2, 2023
@tmarti tmarti deleted the data-tex-smart-deferred-flags branch November 16, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants