Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ewallets endpoints #20

Merged
merged 68 commits into from
Jan 3, 2020
Merged

Ewallets endpoints #20

merged 68 commits into from
Jan 3, 2020

Conversation

ErvanAdetya
Copy link
Contributor

@ErvanAdetya ErvanAdetya commented Dec 29, 2019

  • Create Payment
  • Get Payment

Copy link
Contributor

@stanleynguyen stanleynguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ErvanAdetya, thank you so much for the effort put in, the code looks awesome. Just a few points that I would need your help with:

  • Having 3 separate classes for 3 different ewallets types to solve the problems of LINKAJA not supporting getPayment endpoint is an overkill in my opinion, which leads to code duplication. I think a better approach would be to have just 2 methods one for createPayment and one for getPayment right inside EWallet class and have 2 separate enums CreateSupportWalletTypes and GetSupportWalletTypes
  • Integration tests can be done with both createPayment and getPayment and done without a lot more effort if first point is taken into account, hence, it would be lovely if you can add one more step of getPayment to the current integration test
  • There are some linting warnings that need to be addressed (Github pointed it out here but you can check in your local with npm run lint too)

Copy link
Contributor

@stanleynguyen stanleynguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@stanleynguyen stanleynguyen merged commit fb9d75e into master Jan 3, 2020
@stanleynguyen stanleynguyen deleted the story/API-767 branch January 11, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants