-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ewallets endpoints #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ErvanAdetya
commented
Dec 29, 2019
•
edited
Loading
edited
- Create Payment
- Get Payment
stanleynguyen
suggested changes
Dec 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ErvanAdetya, thank you so much for the effort put in, the code looks awesome. Just a few points that I would need your help with:
- Having 3 separate classes for 3 different ewallets types to solve the problems of LINKAJA not supporting getPayment endpoint is an overkill in my opinion, which leads to code duplication. I think a better approach would be to have just 2 methods one for createPayment and one for getPayment right inside
EWallet
class and have 2 separate enumsCreateSupportWalletTypes
andGetSupportWalletTypes
- Integration tests can be done with both
createPayment
andgetPayment
and done without a lot more effort if first point is taken into account, hence, it would be lovely if you can add one more step ofgetPayment
to the current integration test - There are some linting warnings that need to be addressed (Github pointed it out here but you can check in your local with
npm run lint
too)
stanleynguyen
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because there's no sandbox env for eWalelt for integration tests to be run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.