Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boolean flags #250

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

nikoladze
Copy link

The command line arguments --complete, --purge and --stat have been configured in the original autojump implementation with action="store_true", compare e.g.

https://github.com/wting/autojump/blob/06e082c91805cb022900819b2e0881eeae780d58/bin/autojump#L120

To achieve the same here i added an ArgAction::SetTrue and changed app.contains_id to app.get_flag for these options. Now for me the fzf integration code snippet works again which makes use of the -s option and was broken with autojump-rs. For me autocompletion also seems to work now, so I think #213 should also be fixed by this PR.

@xen0n
Copy link
Owner

xen0n commented May 25, 2023

Not sure why the CI (specifically the i686-linux-android job) is failing, but the change should not be responsible for that; I'll have to process this later but I expect to merge this eventually. Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants