SshConnection can now bind to a specific local host address and/or local port

[bastiaanb]

Adds ability to bind to a specific local host address and/or local port to SshConnection via options 'bindAddress' and 'bindPort', like OpenSSHs' '-b' parameter.
Binding to a specific local address or port may be necessary for compliance with network policies (e.g. routing or firewall settings).

[buildhive]

XebiaLabs » overthere #215 SUCCESS
This pull request looks good
(what's this?)

[vpartington]

Hi @bastiaanb, thanks for your pull request. Being able to specify the bind address and bind port sounds like a useful addition to Overthere.

Unfortunately I'm a little busy right now, so I'll review it next week and get back to you!

Regards, Vincent.

[demobox]

Are we sure supplying 0.0.0.0 and 0 here is the same as not supplying anything? Looking at the code, this seems to cause an additional call to Socket.bind, and there does not seem to be any indication that if you do not make that explicit call, it will bind to 0.0.0.0:0.

Instead use something like the following here?

bindAddress = options.get(BIND_ADDRESS);
...
if (bindAddress == null) {
  client.connect(host, port);
} else {
  client.connect(host, port, InetAddress.getByName(bindAddress), bindPort);
}

?

[bastiaanb]

Agreed. Using a magic value '0.0.0.0' is not nice in any case and may yield different results. E.g. in case of IPv6.
If if-construct alternative does not support the option of specifying a port but not an address. Tha'ts acceptable I guess.

[bastiaanb]

I will create a new pull with suggested improvements.
@demobox thanks for the comments!

[demobox]

@bastiaanb @vpartington Ping..?

[hierynomus]

Bastiaan created a new PR for this ;)

[demobox]

Bastiaan created a new PR for this ;)

Ah, #131, I see...