dialects: (math) Use SameOperandsAndResultType trait
#3761
+86
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compor
commented
Jan 17, 2025
|
|
||
| def __init__( | ||
| self, operand: Operation | SSAValue, fastmath: FastMathFlagsAttr | None = None | ||
| ): | ||
| operand = SSAValue.get(operand) | ||
| return super().__init__( |
There was a problem hiding this comment.
Piggybacked this change as pylint was complaining.
compor
force-pushed
the
christos/dialects/math/use-same-operands-and-result-type-trait
branch
from
b84370e to
c97e740
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## christos/core/traits/same-operands-and-result-types #3761 +/- ##
=======================================================================================
- Coverage 91.26% 91.26% -0.01%
=======================================================================================
Files 461 461
Lines 57454 57433 -21
Branches 5545 5545
=======================================================================================
- Hits 52437 52416 -21
Misses 3591 3591
Partials 1426 1426 ☔ View full report in Codecov by Sentry. |
|
No sure I understand the CI lockfile fail, but I'll have a look later |
superlopuh
approved these changes
Jan 17, 2025
I don't think anything, really, that was my goal with this. |
compor
commented
Jan 17, 2025
| from xdsl.utils.exceptions import VerifyException | ||
| from xdsl.utils.test_value import TestSSAValue | ||
|
|
||
| _BinOpArgT = TypeVar("_BinOpArgT", bound=Attribute) |
There was a problem hiding this comment.
This is unused. Not sure what the initial outlook here was.
|
Nice, I think separate PR is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SameOperandsAndResultTypetrait in themathdialectreturn_typeparameterStacked on: #3751