misc: Stencil and csl lowering fixes #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01%
==========================================
Files 457 459 +2
Lines 57601 57631 +30
Branches 5549 5564 +15
==========================================
+ Hits 51948 51984 +36
- Misses 4192 4201 +9
+ Partials 1461 1446 -15 ☔ View full report in Codecov by Sentry. |
50 tasks
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Various minor fixes: * `stencil`: Add canonicalisation pattern for `stencil.cast` where input type == output type * `csl-stencil-handle-async-flow`: When creating a function call graph, copy arith constants to the function in which they are used, undoing mlir-opt canonicalisation moving them around. * `test-add-timers-to-top-level-funcs`: Generate timers as `private` functions --------- Co-authored-by: n-io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor fixes:
stencil: Add canonicalisation pattern forstencil.castwhere input type == output typecsl-stencil-handle-async-flow: When creating a function call graph, copy arith constants to the function in which they are used, undoing mlir-opt canonicalisation moving them around.test-add-timers-to-top-level-funcs: Generate timers asprivatefunctions