Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformations: (lower-csl-stencil) Add iter args to first region #3304

Merged
merged 1 commit into from
Oct 15, 2024
Merged

transformations: (lower-csl-stencil) Add iter args to first region #3304

merged 1 commit into from
Oct 15, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Oct 15, 2024

Translate block args for both regions alike in csl_stencil.apply lowering.

@n-io n-io added bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Oct 15, 2024
@n-io n-io requested review from AntonLydike and dk949 October 15, 2024 13:41
@n-io n-io self-assigned this Oct 15, 2024
@n-io n-io mentioned this pull request Oct 15, 2024
Open
50 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (70fa878) to head (d693eb5).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3304    +/-   ##
========================================
  Coverage   90.01%   90.01%            
========================================
  Files         445      445            
  Lines       55850    55970   +120     
  Branches     5351     5365    +14     
========================================
+ Hits        50274    50384   +110     
- Misses       4169     4177     +8     
- Partials     1407     1409     +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dk949
dk949 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@n-io n-io merged commit 877b70c into main Oct 15, 2024
14 checks passed
@n-io n-io deleted the nicolai/csl-load-store-in-first-region branch October 15, 2024 14:00
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
@n-io @EdmundGoodman
transformations: (lower-csl-stencil) Add iter args to first region (x…
379fb23 
…dslproject#3304)

Translate block args for both regions alike in `csl_stencil.apply`
lowering.

Co-authored-by: n-io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk949 dk949 dk949 approved these changes

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

Assignees

@n-io n-io

Labels
bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-io @dk949