Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (csl) adjusted width and height of the PE #3209

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 23, 2024

They need to be 2 greater than the dmp topology

@n-io Could you please let me know if this looks right?

They need to be 2 greater than the dmp topology
@dk949 dk949 added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Sep 23, 2024
@dk949 dk949 requested a review from n-io September 23, 2024 16:00
@dk949 dk949 self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (5349938) to head (ff0c6be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3209   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files         433      433           
  Lines       54568    54568           
  Branches     8465     8465           
=======================================
+ Hits        49133    49135    +2     
+ Misses       4061     4060    -1     
+ Partials     1374     1373    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@n-io n-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better not to hard-code this, though if we want a simple fix, we can adjust width and height by adding 2*(pattern-1), which I believe is 2*max_distance. Best done outside the loop.

@dk949
Copy link
Collaborator Author

dk949 commented Sep 24, 2024

I think it's better not to hard-code this, though if we want a simple fix, we can adjust width and height by adding 2*(pattern-1), which I believe is 2*max_distance. Best done outside the loop.

👍

Sounds good.

@dk949 dk949 merged commit 2916539 into main Sep 25, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-transforms/dimensions-fix branch September 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants