-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel vae #281
Fix parallel vae #281
Conversation
Related PR xdit-project/DistVAE#3 To consider DP, we add
Then use default group to complete parallel vae. When using parallel vae, only one process need to process img after vae. So |
I think it is not a elegant implementation because you combined all the dp latents into one tensor instead of using different dp groups to process different latent. It will increase the communication load. |
It is indeed not the best implementation. Using different dp groups need to refactor DistVAE. Since parallel vae is an option, maybe we can first fix parallel vae in this PR, and further optimize it in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
related to #271