Remove TONUpload class #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaeda-ks
force-pushed
the
smaeda-ks/develop/remove-ton
branch
from
6a04d6c to
d942c97
Compare
jbabichjapan
approved these changes
Jun 5, 2019
smaeda-ks
added a commit
that referenced
this pull request
Jun 14, 2019
* Support for media library, media creative and account media endpoints (#185) * Bump version to v4 (#186) * make error handling image be shown (#177) * update twitter-ads version to 4.0.1 (#187) * Fix Rubocop Rules (#189) * update twitter-ads version to 4.0.1 * update rubocop.yml and tailored_audience.rb * Update to v5 (#191) * Added support for MEDIA_CREATIVE stats * added support for card_uris * updated example for v5 * updated TC line_item_id to line_item_ids * added support for with_draft * remove preview_url from all cards endpoints * Tailored Audience for v4 (#180) * Add a comment to TailoredAudience.users * Rename create_instance to create The current create method will no longer be supported as of v4. * Delele unused methods * Add (start|end)_time property to LineItem class #178 (#193) * Remove TONUpload class (#192) * Update SDK to support Ruby 2.3+ (#190) * Remove CI guards * Start upgrade to min 2.3. Rubocop auto fixes * Disable and update a handful of Rubocop warnings Disabled Linting warnings on using Void and URI:Escape * Update copyright * Test ruby 2.3+ on Travis CI * Add Ruby 2.6 to build matrix and correct copyright lint * Minor fix to copyright * Add rubocop as separate step to display errors * Make rubocop verbose to help debugging * Remove erroneous newline * Fix merge conflicts * Revert "Remove CI guards" This reverts commit 85db938. * Update supported Ruby versions and bump license year * Update LICENSE * Fix merge conflicts * Add ActiveEntities support (#195) * Add ActiveEntities support * Update style * Add new preview endpoint support (#194) * Minor bug fixes (#197) * Fix promoted_tweet example * Fix TypeError > no implicit conversion of nil into Hash (TypeError) when with_deleted is false * Improve Travis CI Tests (#196) * Update .travis.yml * Update README We no longer test JRuby since #133 * Set min version to 2.4 * Allow bundler 2 * Update .rubocop.yml * Update twitter-ads version to 5.1.0 (#198) * [docs] updating v5.1.0 documentation
smaeda-ks
added a commit
to esakai/twitter-ruby-ads-sdk
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tushdante @juanshishido