Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ads API v4] Minor changes #179

Merged
merged 5 commits into from
Sep 10, 2018
Merged

[Ads API v4] Minor changes #179

merged 5 commits into from
Sep 10, 2018

Conversation

tushdante
Copy link
Collaborator

Issue Type: Improvement

Changes Included:

  • Changed all references of app_country_code to country_code
  • Removed videos endpoint
  • Added support for the lookalike_expansion param on the line items endpoint and updated enum values for the same

Check List:

For more information on check list items, please see the Contributors Guide.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jbabichjapan
jbabichjapan approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@jbabichjapan jbabichjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we didn't have any 'Examples' that touched the videos endpoint - we definitely need to add some media workflow examples as a separate work item...

@jbabichjapan jbabichjapan merged commit f5397a5 into master Sep 10, 2018
abhishekgupta5 pushed a commit to abhishekgupta5/twitter-ruby-ads-sdk that referenced this pull request Dec 20, 2018
@tushdante @abhishekgupta5
[Ads API v4] Minor changes (xdevplatform#179)
d5285d4 
* added support for lookalike expansion

* update references to country_code

* removed videos endpoint

* updated spec files

* removed additional references to videos endpoint; updated the spec as well
abhishekgupta5 pushed a commit to abhishekgupta5/twitter-ruby-ads-sdk that referenced this pull request Feb 17, 2019
@tushdante @abhishekgupta5
[Ads API v4] Minor changes (xdevplatform#179)
f8effbc 
* added support for lookalike expansion

* update references to country_code

* removed videos endpoint

* updated spec files

* removed additional references to videos endpoint; updated the spec as well
smaeda-ks pushed a commit to esakai/twitter-ruby-ads-sdk that referenced this pull request Jun 18, 2019
@tushdante @smaeda-ks
[Ads API v4] Minor changes (xdevplatform#179)
958717b 
* added support for lookalike expansion

* update references to country_code

* removed videos endpoint

* updated spec files

* removed additional references to videos endpoint; updated the spec as well
@smaeda-ks smaeda-ks deleted the tbhushan/minor_changes branch September 25, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbabichjapan jbabichjapan jbabichjapan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tushdante @CLAassistant @jbabichjapan