Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename user_ids to user_id in Account#timeline #176

Merged
merged 20 commits into from
Jun 18, 2019
Merged

Rename user_ids to user_id in Account#timeline #176

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b4e5551
Rename user_ids to user_id in Account#timeline
esakai May 14, 2018
958717b
[Ads API v4] Minor changes (#179)
tushdante Sep 10, 2018
033d756
Esakai tailored audience for v4 (#182)
tushdante Feb 12, 2019
b5cfd42
v4 update
tushdante Feb 14, 2019
388b442
Support for media library, media creative and account media endpoints…
Feb 22, 2019
dcb8f30
Bump version to v4 (#186)
smaeda-ks Feb 26, 2019
6eeda36
make error handling image be shown (#177)
treby Feb 26, 2019
b1799ba
update twitter-ads version to 4.0.1 (#187)
tushdante Feb 27, 2019
1452bc3
Fix Rubocop Rules (#189)
tushdante Feb 27, 2019
47b2990
Update to v5 (#191)
tushdante Mar 5, 2019
aaa59db
Tailored Audience for v4 (#180)
esakai May 17, 2019
0febe01
Add (start|end)_time property to LineItem class #178 (#193)
smaeda-ks May 26, 2019
c78ce8b
Remove TONUpload class (#192)
smaeda-ks Jun 5, 2019
a8e9bdc
Update SDK to support Ruby 2.3+ (#190)
osowskit Jun 12, 2019
06ee1e0
Add ActiveEntities support (#195)
smaeda-ks Jun 13, 2019
7bb1884
Add new preview endpoint support (#194)
smaeda-ks Jun 13, 2019
02213c9
Minor bug fixes (#197)
smaeda-ks Jun 14, 2019
b07aae7
Improve Travis CI Tests (#196)
smaeda-ks Jun 14, 2019
96fa7b6
Update twitter-ads version to 5.1.0 (#198)
smaeda-ks Jun 14, 2019
5274f1c
Merge branch 'master' into rename-user_ids-to-user_id-in-account-time…
smaeda-ks Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/twitter-ads/account.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,8 @@ def tailored_audiences(id = nil, opts = {})
# @return [Array] An Array of Tweet objects.
#
# @since 0.2.3
def scoped_timeline(ids, opts = {})
ids = ids.join(',') if ids.is_a?(Array)
params = { user_ids: ids }.merge!(opts)
def scoped_timeline(id, opts = {})
params = { user_id: id }.merge!(opts)
resource = SCOPED_TIMELINE % { id: @id }
request = Request.new(client, :get, resource, params: params)
response = request.perform
Expand Down