Skip to content

Commit

Permalink
Improve Travis CI Tests (#196)
Browse files Browse the repository at this point in the history
* Update .travis.yml

* Update README

We no longer test JRuby since #133

* Set min version to 2.4

* Allow bundler 2

* Update .rubocop.yml
  • Loading branch information
smaeda-ks committed Jun 18, 2019
1 parent 02213c9 commit b07aae7
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 17 deletions.
5 changes: 4 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Style & Quality Overrides
AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.4
Exclude:
- 'bin/**/*'
- 'vendor/bundle/**/*'
Expand Down Expand Up @@ -138,3 +138,6 @@ Layout/EmptyLineAfterMagicComment:

Metrics/BlockLength:
Enabled: false

Performance/RegexpMatch:
Enabled: false
17 changes: 9 additions & 8 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
language: ruby

install: ruby -S bundle install --without development
before_install:
- bundle config without 'development'

install: bundle install
script: bundle exec rake

branches:
only:
- master
- stable

matrix:
fast_finish: true
allow_failures:
- rvm: ruby-head
- rvm: rbx
- rvm: rbx-2
include:
- rvm: 2.3.0
- rvm: 2.4.0
- rvm: 2.5.0
- rvm: 2.6.0
- rvm: 2.6.3
- rvm: 2.5.5
- rvm: 2.4.6
- rvm: ruby-head
- rvm: rbx
- rvm: rbx-2
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,11 @@ For more help please see our [Examples and Guides](https://github.com/twitterdev

## Compatibility & Versioning

This project is designed to work with Ruby 2.3.0 or greater. While it may work on other version of Ruby, below are the platform and runtime versions we officially support and regularly test against.
This project is designed to work with Ruby 2.4.0 or greater. While it may work on other version of Ruby, below are the platform and runtime versions we officially support and regularly test against.

Platform | Versions
-------- | --------
MRI | 2.3.0, 2.4.x, 2.5.x, 2.6.x
JRuby | 1.7.x, 9.0.0.0 (JDK7, JDK8, OpenJDK)
MRI | 2.4.x, 2.5.x, 2.6.x
Rubinius | 2.4.x, 2.5.x

All releases adhere to strict [semantic versioning](http://semver.org). For Example, major.minor.patch-pre (aka. stick.carrot.oops-peek).
Expand Down
14 changes: 9 additions & 5 deletions twitter-ads.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,20 @@ Gem::Specification.new do |s|
s.version = TwitterAds::VERSION
s.platform = Gem::Platform::RUBY
s.licenses = ['MIT']
s.authors = ['Brandon Black', 'John Babich', 'Jacob Petrie']
s.authors = [
'John Babich',
'Tushar Bhushan',
'Juan Shishido',
'Thomas Osowski',
'Shohei Maeda'
]
s.email = ['[email protected]']
s.homepage = 'https://github.com/twitterdev/twitter-ruby-ads-sdk'
s.description = 'The officially supported Twitter Ads API SDK for Ruby.'
s.summary = s.description

s.required_ruby_version = '>= 2.3.0'
s.required_rubygems_version = '>= 2.3.0'
s.required_ruby_version = '>= 2.4.0'
s.required_rubygems_version = '>= 2.6.0'

if File.exist?('private.pem')
s.signing_key = 'private.pem'
Expand All @@ -27,8 +33,6 @@ Gem::Specification.new do |s|
s.add_dependency 'multi_json', '~> 1.11'
s.add_dependency 'oauth', '~> 0.4'

s.add_development_dependency 'bundler', '~> 1.6'

s.files = Dir.glob('{bin,lib}/**/*')
s.files += %w(twitter-ads.gemspec LICENSE README.md CONTRIBUTING.md Rakefile)
s.test_files = Dir.glob('{spec,feature}/**/*')
Expand Down

0 comments on commit b07aae7

Please sign in to comment.