Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use the pre-built binaries with travis? #359

Closed
najamelan opened this issue Feb 29, 2020 · 7 comments
Closed

How to use the pre-built binaries with travis? #359

najamelan opened this issue Feb 29, 2020 · 7 comments

Comments

@najamelan
Copy link
Contributor

I was hoping to use cargo tarpaulin on travis, in the standard linux configuration which is travis-ci-opal-xenial-1553530491-f909ac5. The readme says:

Alternative, there is the travis-install shell script will install the latest tagged release built on travis to your travis instance and significantly speeds up the travis builds. You can install via that script using bash <(curl https://raw.githubusercontent.com/xd009642/tarpaulin/master/travis-install.sh).

It never finds libssl.so.1.1. I tried installing the packages libssl-dev and openssl, but it won't find the dynamic lib...

@xd009642
Copy link
Owner

xd009642 commented Mar 1, 2020

Could you try with dist: trusty and libssl-dev? I remember having some issues with the other ubuntu versions available on travis

@najamelan
Copy link
Contributor Author

So I ran some more tests:

  • trusty: The issue is the same. Config
  • bionic: It works! by installing libssl-dev

I will file a PR to update the readme.

@xd009642
Copy link
Owner

xd009642 commented Mar 1, 2020

So the minimum recommended travis setup has sudo: required I wouldn't expect it to fix anything but I also wouldn't expect coverage to work without it because you can't disable ASLR

@najamelan
Copy link
Contributor Author

Ok, I'll double check with sudo: required just in case.

@najamelan
Copy link
Contributor Author

trusty: also fails with sudo, but is version: libssl-dev amd64 1.0.1f-1ubuntu2.27, so it's just a not 1.1 as tarpaulin has been compiled against I think.
xenial: fails, libssl version: 1.0.2g-1ubuntu4.15

bionic has libssl-dev amd64 1.1.1-1ubuntu2.1~18.04.5. Bionic does not need sudo: required

An added nuissance is that by putting it as an inline script in the travis yaml:

      after_success: |
        bash <(curl https://raw.githubusercontent.com/xd009642/tarpaulin/master/travis-install.sh)
        cargo tarpaulin --features "spawn_handle async_std tokio_tp tokio_ct localpool threadpool" --exclude-files src/bindgen.rs --out Xml
        bash <(curl -s https://codecov.io/bash)

This will report the built successful even if the codecov script concludes with "no coverage data found". Probably needs some set -e for fast failure.

najamelan added a commit to najamelan/tarpaulin that referenced this issue Mar 1, 2020
Closes xd009642#359

I think it would be great if tarpaulin had CI itself to verify that all
recommended installation procedures actually lead to working setups.

Unfortunately I don't have the time to set that up for you.
@xd009642
Copy link
Owner

xd009642 commented Mar 3, 2020

@najamelan does the PR merged solve this issue? Or are there more documentation changes that would help?

@najamelan
Copy link
Contributor Author

If I were you, I would create CI configurations that actually run on travis, which would prove that they work and then point to them in the readme, but this already is definitely great improvement. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants