Usage of Toolbutton component instead of Toggle Button #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchimotwaniBC
changed the title
forman
requested changes
Jun 27, 2024
| selected={variableColorBar.isAlpha} | ||
| onClick={handleColorBarAlpha} | ||
| onChange | ||
| icon={<OpacityIcon fontSize="small" />} |
There was a problem hiding this comment.
Suggested change
| icon={<OpacityIcon fontSize="small" />} | |
| icon={<OpacityIcon fontSize="inherit" />} |
See original code.
| onClick={handleColorBarReversed} | ||
| onChange | ||
| tooltipText={i18n.get("Reverse")} | ||
| icon={<InvertColorsIcon fontSize="small" />} |
| Note, it is actually not ok to use toggle button here as it | ||
| just opens a popup. However, we should use the toggle button | ||
| to indicate that a fixed y-range is active. | ||
| */} | ||
| <Tooltip title={i18n.get("Enter fixed y-range")}> |
There was a problem hiding this comment.
Why not using tooltipText property?
| <ToolButton | ||
| toggle | ||
| value="point" | ||
| icon={<ScatterPlotIcon fontSize="small" />} |
| <ToolButton | ||
| toggle | ||
| value="line" | ||
| icon={<ShowChartIcon fontSize="small" />} |
| event: MouseEvent<HTMLButtonElement | HTMLElement>, | ||
| value?: string, | ||
| ) => void; | ||
| onChange?: boolean; |
There was a problem hiding this comment.
Suggested change
| onChange?: boolean; | |
| onChange?: boolean; |
You should only name properties on<Event> if they are event handlers, not boolean flags. What is it for?
| @@ -77,6 +84,7 @@ const ToolButton: React.FC<ToolButtonProps> = ({ | |||
| disabled={disabled} | |||
| size="small" | |||
| onClick={handleClick} | |||
| onChange={onChange ? handleClick : undefined} | |||
| import InvertColorsIcon from "@mui/icons-material/InvertColors"; | ||
| import OpacityIcon from "@mui/icons-material/Opacity"; | ||
|
|
||
| import i18n from "@/i18n"; | ||
| import { ColorBar, formatColorBarName } from "@/model/colorBar"; | ||
| import { ColorBarNorm } from "@/model/variable"; | ||
| import { SxProps, Theme } from "@mui/system"; | ||
| import ToolButton from "../ToolButton"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.