feat(parser/renderer): support 'header' and 'footer' options in tables (

bytesparadise#862) Supports the shorthand (`%header%footer`) syntax and the explicit one (`options="header,footer"`) also, fixes a bug in column settings when multiplier is used Fixes bytesparadise#861 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon · Nov 21, 2021 · f1156b7 · f1156b7
1 parent efe9f73
commit f1156b7
Show file tree

Hide file tree

Showing 12 changed files with 570 additions and 56 deletions.
diff --git a/pkg/parser/attributes_test.go b/pkg/parser/attributes_test.go
@@ -522,12 +522,39 @@ var _ = DescribeTable("valid block attributes",
 		},
 	),
 
+	// options (explicit)
+	Entry(`[options=header]`, `[options=header]`,
+		types.Attributes{
+			types.AttrOptions: []interface{}{"header"},
+		},
+	),
+	Entry(`[options="header,footer"]`, `[options="header,footer"]`,
+		types.Attributes{
+			types.AttrOptions: []interface{}{"header", "footer"},
+		},
+	),
+
 	// option shorthand
 	Entry(`[%hardbreaks]`, `[%hardbreaks]`,
 		types.Attributes{
 			types.AttrOptions: []interface{}{"hardbreaks"},
 		},
 	),
+	Entry(`[%header]`, `[%header]`,
+		types.Attributes{
+			types.AttrOptions: []interface{}{"header"},
+		},
+	),
+	Entry(`[%footer]`, `[%footer]`,
+		types.Attributes{
+			types.AttrOptions: []interface{}{"footer"},
+		},
+	),
+	Entry(`[%header%footer]`, `[%header%footer]`,
+		types.Attributes{
+			types.AttrOptions: []interface{}{"header", "footer"},
+		},
+	),
 
 	// id (alone)
 	Entry(`[#an_id]`, `[#an_id]`,

diff --git a/pkg/parser/document_processing_apply_substitutions.go b/pkg/parser/document_processing_apply_substitutions.go
@@ -170,6 +170,11 @@ func applySubstitutionsOnBlockWithElements(ctx *ParseContext, block types.BlockW
 				return err
 			}
 		}
+		if b.Footer != nil {
+			if err = s.processBlockWithElements(ctx, b.Footer, opts...); err != nil {
+				return err
+			}
+		}
 	}
 	if err := s.processBlockWithElements(ctx, block, opts...); err != nil {
 		return err