test(parser/renderer): verify quoted text role with specoal chars

issue was fixed by bytesparadise#755, verifying it here Fixes bytesparadise#748 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon · Sep 28, 2020 · 856c40a · 856c40a
1 parent 2179d24
commit 856c40a
Show file tree

Hide file tree

Showing 2 changed files with 123 additions and 74 deletions.
diff --git a/pkg/parser/quoted_text_test.go b/pkg/parser/quoted_text_test.go
@@ -447,7 +447,7 @@ var _ = Describe("quoted texts", func() {
 			})
 		})
 
-		Context("Quoted text with double punctuation", func() {
+		Context("quoted text with double punctuation", func() {
 
 			It("bold text of 1 word in double quote", func() {
 				source := "**hello**"
@@ -637,7 +637,7 @@ var _ = Describe("quoted texts", func() {
 			})
 		})
 
-		Context("Quoted text inline", func() {
+		Context("quoted text inline", func() {
 
 			It("inline content with bold text", func() {
 				source := "a paragraph with *some bold content*"
@@ -1133,6 +1133,44 @@ var _ = Describe("quoted texts", func() {
 				Expect(ParseDraftDocument(source)).To(MatchDraftDocument(expected))
 			})
 
+			It("short-hand role with special characters", func() {
+				source := "[\"a <role>\"]**bold**"
+				expected := types.DraftDocument{
+					Blocks: []interface{}{
+						types.Paragraph{
+							Lines: []interface{}{
+								[]interface{}{
+									types.QuotedText{
+										Kind: types.Bold,
+										Attributes: types.Attributes{
+											types.AttrRole: types.ElementRole{
+												types.StringElement{
+													Content: "a ",
+												},
+												// wrapping quotes are not preserved
+												types.SpecialCharacter{
+													Name: "<",
+												},
+												types.StringElement{
+													Content: "role",
+												},
+												types.SpecialCharacter{
+													Name: ">",
+												},
+											},
+										},
+										Elements: []interface{}{
+											types.StringElement{Content: "bold"},
+										},
+									},
+								},
+							},
+						},
+					},
+				}
+				Expect(ParseDraftDocument(source)).To(MatchDraftDocument(expected))
+			})
+
 			It("marked short-hand role only", func() {
 				source := "[.bob]##the builder##"
 				expected := types.DraftDocument{
@@ -3794,7 +3832,7 @@ var _ = Describe("quoted texts", func() {
 
 		})
 
-		Context("Quoted text with double punctuation", func() {
+		Context("quoted text with double punctuation", func() {
 
 			It("bold text of 1 word in double quote", func() {
 				source := "**hello**"
@@ -4022,7 +4060,7 @@ var _ = Describe("quoted texts", func() {
 
 		})
 
-		Context("Quoted text inline", func() {
+		Context("quoted text inline", func() {
 
 			It("inline content with bold text", func() {
 				source := "a paragraph with *some bold content*"
@@ -6090,29 +6128,29 @@ var _ = Describe("quoted texts", func() {
 				})
 			})
 		})
-	})
 
-	Context("final document", func() {
+		Context("nested images", func() {
 
-		It("image in bold", func() {
-			source := "*a image:foo.png[]*"
-			expected := types.Document{
-				Elements: []interface{}{
-					types.Paragraph{
-						Lines: []interface{}{
-							[]interface{}{
-								types.QuotedText{
-									Kind: types.Bold,
-									Elements: []interface{}{
-										types.StringElement{Content: "a "},
-										types.InlineImage{
-											Attributes: types.Attributes{
-												types.AttrImageAlt: "foo",
-											},
-											Location: types.Location{
-												Path: []interface{}{
-													types.StringElement{
-														Content: "foo.png",
+			It("image in bold", func() {
+				source := "*a image:foo.png[]*"
+				expected := types.Document{
+					Elements: []interface{}{
+						types.Paragraph{
+							Lines: []interface{}{
+								[]interface{}{
+									types.QuotedText{
+										Kind: types.Bold,
+										Elements: []interface{}{
+											types.StringElement{Content: "a "},
+											types.InlineImage{
+												Attributes: types.Attributes{
+													types.AttrImageAlt: "foo",
+												},
+												Location: types.Location{
+													Path: []interface{}{
+														types.StringElement{
+															Content: "foo.png",
+														},
 													},
 												},
 											},
@@ -6122,30 +6160,30 @@ var _ = Describe("quoted texts", func() {
 							},
 						},
 					},
-				},
-			}
-			Expect(ParseDocument(source)).To(MatchDocument(expected))
-		})
+				}
+				Expect(ParseDocument(source)).To(MatchDocument(expected))
+			})
 
-		It("image in italic", func() {
-			source := "_a image:foo.png[]_"
-			expected := types.Document{
-				Elements: []interface{}{
-					types.Paragraph{
-						Lines: []interface{}{
-							[]interface{}{
-								types.QuotedText{
-									Kind: types.Italic,
-									Elements: []interface{}{
-										types.StringElement{Content: "a "},
-										types.InlineImage{
-											Attributes: types.Attributes{
-												types.AttrImageAlt: "foo",
-											},
-											Location: types.Location{
-												Path: []interface{}{
-													types.StringElement{
-														Content: "foo.png",
+			It("image in italic", func() {
+				source := "_a image:foo.png[]_"
+				expected := types.Document{
+					Elements: []interface{}{
+						types.Paragraph{
+							Lines: []interface{}{
+								[]interface{}{
+									types.QuotedText{
+										Kind: types.Italic,
+										Elements: []interface{}{
+											types.StringElement{Content: "a "},
+											types.InlineImage{
+												Attributes: types.Attributes{
+													types.AttrImageAlt: "foo",
+												},
+												Location: types.Location{
+													Path: []interface{}{
+														types.StringElement{
+															Content: "foo.png",
+														},
 													},
 												},
 											},
@@ -6155,30 +6193,30 @@ var _ = Describe("quoted texts", func() {
 							},
 						},
 					},
-				},
-			}
-			Expect(ParseDocument(source)).To(MatchDocument(expected))
-		})
+				}
+				Expect(ParseDocument(source)).To(MatchDocument(expected))
+			})
 
-		It("image in monospace", func() {
-			source := "`a image:foo.png[]`"
-			expected := types.Document{
-				Elements: []interface{}{
-					types.Paragraph{
-						Lines: []interface{}{
-							[]interface{}{
-								types.QuotedText{
-									Kind: types.Monospace,
-									Elements: []interface{}{
-										types.StringElement{Content: "a "},
-										types.InlineImage{
-											Attributes: types.Attributes{
-												types.AttrImageAlt: "foo",
-											},
-											Location: types.Location{
-												Path: []interface{}{
-													types.StringElement{
-														Content: "foo.png",
+			It("image in monospace", func() {
+				source := "`a image:foo.png[]`"
+				expected := types.Document{
+					Elements: []interface{}{
+						types.Paragraph{
+							Lines: []interface{}{
+								[]interface{}{
+									types.QuotedText{
+										Kind: types.Monospace,
+										Elements: []interface{}{
+											types.StringElement{Content: "a "},
+											types.InlineImage{
+												Attributes: types.Attributes{
+													types.AttrImageAlt: "foo",
+												},
+												Location: types.Location{
+													Path: []interface{}{
+														types.StringElement{
+															Content: "foo.png",
+														},
 													},
 												},
 											},
@@ -6188,9 +6226,9 @@ var _ = Describe("quoted texts", func() {
 							},
 						},
 					},
-				},
-			}
-			Expect(ParseDocument(source)).To(MatchDocument(expected))
+				}
+				Expect(ParseDocument(source)).To(MatchDocument(expected))
+			})
 		})
 	})
 })
diff --git a/pkg/renderer/sgml/html5/quoted_text_test.go b/pkg/renderer/sgml/html5/quoted_text_test.go
@@ -315,6 +315,7 @@ content</mark>.</p>
 	})
 
 	Context("attributes", func() {
+
 		It("simple role italics", func() {
 			source := "[myrole]_italics_"
 			expected := `<div class="paragraph">
@@ -360,6 +361,16 @@ content</mark>.</p>
 			Expect(RenderHTML(source)).To(MatchHTML(expected))
 		})
 
+		It("short-hand role with special characters", func() {
+			source := `["a <role>"]**bold**`
+			// wrapping quotes are not preserved
+			expected := `<div class="paragraph">
+<p><strong class="a &lt;role&gt;">bold</strong></p>
+</div>
+`
+			Expect(RenderHTML(source)).To(MatchHTML(expected))
+		})
+
 		It("simple role mono unconstrained", func() {
 			source := "int[uncle]``eg``rate"
 			expected := `<div class="paragraph">